Implement inclusive/exclusive trade fees into dca calculations.

stayradiated / volatile

A service for automating cryptocurrency trading.

https://volatile.co.nz

2 stars 4 forks source link

Implement inclusive/exclusive trade fees into dca calculations. #25

Open stayradiated opened 3 years ago

stayradiated commented 3 years ago

KiwiCoin has an inclusive fee: Bidding $100 @ $100/BTC with 1% inclusive fee: Spend $100 and receive 0.99 BTC

Dasset has an exclusive fee: Bidding $100 @ $100/BTC with 1% exclusive fee: Spend $101 and receive 1 BTC

stayradiated commented 2 years ago

This is quite important -- the way we do this at the moment is very hacky and annoying. It would be good to store fee % in the database, I guess we would need maker/taker fees.

Perhaps with a user override so they can configure their own fees? Seems a bit overkill..,

stayradiated commented 2 years ago

Kiwi-Coin: https://kiwi-coin.com/about.html#!/fees/
Dasset: https://www.dassetx.com/fees
Independent Reserve: https://www.independentreserve.com/help/fees

stayradiated commented 2 years ago

I think the best way to handle this for now is to always treat the fee as inclusive. i.e. when we place an order for $100 that should include any fees. Total spent should be $100.