stcarrez / ada-util

Ada Utility Library - Composing streams, processes, logs, serialization, encoders and more
Apache License 2.0
69 stars 14 forks source link

Make it compile and cleanup warnings. #12

Closed persan closed 2 years ago

stcarrez commented 3 years ago

I think the change on src/sys/http/aws/util-http-clients-aws__1.adb is not correct. This file is intended to be used with old versions of AWS because the Add operation is available through a Set package.

The file that should be used for you is src/sys/http/aws/util-http-clients-aws__2.adb. And the root cause is probably because you are using an AWS version that is not yet recognized by configure. One way to fix that is by changing configure.ac arround:

case $AWS_VERSION in
  *2017*|*2018*|*2019*|*202*|20.0)
     UTIL_AWS_VERSION=2
     ;;

Another way is by changing the line in utilada_conf.gpr:

   AWS_Impl    : AWS_Impl_Type := "2"; 

I don't know how to improve this area to detect the version of AWS. Indeed, there are some AWS features which are not available on old versions and I still have some platforms with old AWS implementation. I need to support both.

stcarrez commented 2 years ago

I'm closing this pull request because the root cause was fixed since the pull request was made. Thanks for your submission.