search

stchang / redis

A redis client for Racket.
17 stars 4 forks source link

Fix custodian bug, clean up, add tests #10

Closed m4burns closed 9 years ago

m4burns commented 9 years ago

Bug: When connection-pool-lease called connect in the context of a custodian that was later shut down, the connection returned to the pool would be forcibly closed.

Temperamental part of release-conn is now wrapped in a handler that displays any exn? and abandons the connection.

stchang commented 9 years ago

Thanks for the fixes @m4burns. I also merged most of your old pull request (#9).

Is it ok if I merge the cleanup branch to master now? It has some backward-incompatible changes to the API but it sounds like you were already using the cleanup branch?

m4burns commented 9 years ago

Yes, that's fine! I have indeed been using the cleanup branch.

I just noticed that you put my name in the docs. Thanks!

I'd like to spend some time cleaning up the docs. Is that okay with you?

stchang commented 9 years ago

Yes anything you want to do to improve the docs would be great!