search

stchris / untangle

Converts XML to Python objects
MIT License
611 stars 83 forks source link

remove unnecessary shebang #140

Closed xambroz closed 6 months ago

xambroz commented 6 months ago

As file untangle.py is meant to be used only via import and not as directly executed commandline tool the shebang on the beginning is not needed.

The usage of the env python can also have its security implications.

Having shebang on non-executable file is even being reported as error by some tools - for example Fedora/Red Hat's rpmlint: https://bugzilla.redhat.com/show_bug.cgi?id=2250689#c4

Best regards Michal Ambroz

stchris commented 6 months ago

Thanks for this, @xambroz ! I believe this was a relic of the past and it's totally reasonable to remove it. I'll merge this, but I can't make any promises on when it will make a release, unfortunately.