search

stchris / untangle

Converts XML to Python objects
MIT License
612 stars 83 forks source link

Fix unittest #47

Closed reverbc closed 2 years ago

reverbc commented 7 years ago

This PR is addressed to the issues describe in #46

For test_python_keyword case: some of the keywords are Python 3 only (e.g. None) and will cause failure in Py26 and Py27. In this case I've added a few more test cases and use six to distinguish them.

For test_invalid_feature and test_invalid_external_dtd cases: using assertRaises as context manager is a feature in Py27 so not compatible with Py26. Switching back to old-school syntax here for backward compatibility.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 35.514% when pulling 2f78297441f6292d2d22d0e9641079c7846771dd on reverbc:fix-unittest into a18c1712d534a0e84784c43251cb74c91c846b1f on stchris:master.

stchris commented 2 years ago

Closing this after #82