search

stchris / untangle

Converts XML to Python objects
MIT License
612 stars 83 forks source link

Detect valid pathnames before checking whether a path exists (fixes #45) #52

Closed batterseapower closed 2 years ago

batterseapower commented 7 years ago

The easiest fix for #45 is just to catch the ValueError, but this is a more comprehensive solution that should handle the general case where a string is supplied that is not also a valid path name.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.5%) to 31.061% when pulling 0a3830a6f25f1b64044ae6f60f61c72a5a751e77 on batterseapower:master into a18c1712d534a0e84784c43251cb74c91c846b1f on stchris:master.

stchris commented 2 years ago

I'm hoping to fix this in #87 by separating the file lookup logic in the input auto-detection of the parse function.