csview's trim_left and trim_right implicitly assume LTR text

stclib / STC

A modern, user friendly, generic, type-safe and fast C99 container library: String, Vector, Sorted and Unordered Map and Set, Deque, Forward List, Smart Pointers, Bitset and Random numbers.

MIT License

1.34k stars 73 forks source link

csview's trim_left and trim_right implicitly assume LTR text #102

Closed liigo closed 4 weeks ago

liigo commented 4 weeks ago

see https://github.com/rust-lang/rust/issues/30459

tylov commented 4 weeks ago

Thanks, liigo! Since these are new, I simply renamed them to trim_start() and trim_end() as suggested. (also matches with starts_with() and ends_with() functions). I also renamed all the _right(s, len) functions to _tail(s, len) (because _end() is used for iterators).