stcorp / coda

The Common Data Access toolset
http://stcorp.github.io/coda/doc/html/index.html
BSD 3-Clause "New" or "Revised" License
39 stars 17 forks source link

coda-ascbin-cursor.c: Localize variables and add const when possible #49

Closed schwehr closed 4 years ago

schwehr commented 4 years ago

Demonstration of #48. I understand that the project will reject this patch.

svniemeijer commented 4 years ago

I don't see how this adds anything. Static analysers should be able to handle both cases similarly nowadays. In that case it just becomes a matter of style (and what you find more readable).

It is indeed rejected as already clarified in #48.