search

stcorp / coda

The Common Data Access toolset
http://stcorp.github.io/coda/doc/html/index.html
BSD 3-Clause "New" or "Revised" License
37 stars 17 forks source link

coda_expression_from_string: delete parsed_expression if it is set when there is a failure #56

Closed schwehr closed 4 years ago

schwehr commented 4 years ago

Fixes #54

svniemeijer commented 4 years ago

Thanks. I committed a slightly different version though (that is more in line with the coding style): ea4923858ae6aedc9977b85df86c92a3c36ff397

schwehr commented 4 years ago

Typical workflow would be to review this pr and have the author (e.g. @schwehr ) fix it. Then when it's ready, a maintainer (e.g. @svniemeijer ) can rebase & merge or squash & merge. That way, the project ends up documenting of things like:

  1. Who wrote the original fix
  2. Why parts of the fix should change
  3. Make sure that the issue gets mentioned in the commits with a hash reference to link everything
svniemeijer commented 4 years ago

There are many different workflows possible, and what you are describing is just one of them. At the moment the majority of features and fixes do not go via the github issue tracker anyway, and we also don't have any community of external developers to speak of. So the level of traceability that you propose is maybe something we could introduce if we have more external developers (and if the scope of pull requests starts to include considerable code changes instead of very simple bug fixes or typo corrections).

However, I do want to mention that we definitely appreciate the effort that you are putting into trying to harden the code base of this project.