stcorp / coda

The Common Data Access toolset
http://stcorp.github.io/coda/doc/html/index.html
BSD 3-Clause "New" or "Revised" License
39 stars 17 forks source link

install path for python version 3.10 is wrong #90

Closed jdkloe closed 2 years ago

jdkloe commented 2 years ago

After installing coda 2.24 from source, using --enable-python --prefix=$CODA_INSTALL the code builds and installs fine, but I noted that the python module is installed in $CODA_INSTALL/lib/python3.1/site-packages/coda which is the wrong path. It should be in $CODA_INSTALL/lib/python3.10/site-packages/coda

A user can fix this easily by creating a symlink in $HOME/.lib/python3.10/site-packages/ pointing to this wrong location, but I think the software should be corrected as well.

Without the --prefix option, the python module is installed in /usr/local/lib/python3.10/site-packages/ which is correct but the user needs to install using "sudo make install" in this case, which is not possible if the user has no sudo permissions (which is a common case in centrally managed linux installations).

srepmub commented 2 years ago

can't reproduce this with python 3.10 (conda), but looking at configure/config.status, I can see that PYTHON_VERSION is set to 3.1 because of a broken am_cv_python_version macro.. which should be fixed with automake 1.16.2:

https://www.mail-archive.com/search?l=bug-automake@gnu.org&q=subject:%22bug%2344239%5C%3A+%5C%5BPATCH %5C%5D+Python+double%5C-digit+version+detection+broken%22&o=newest&f=1

svniemeijer commented 2 years ago

I've recreated the coda-2.24.tar.gz source package using a more recent version of the autotools and attached it to the release. Let me know if this works.

jdkloe commented 2 years ago

Something seems to not have worked for this updated version. There is no "configure" script in the tar.gz file, so I can not test it without running automake myself.

If I run "autoreconf --install" myself then I can confirm that the path used by the "make install" step is correct and that $INSTALL/lib/python3.10/site-packages/ is used.

My currently installed autoconf version is: autoconf-2.69 and my automake version is: automake-1.16.2

On 31-05-2022 16:20, Sander Niemeijer wrote:

I've recreated the coda-2.24.tar.gz source package using a more recent version of the autotools and attached it to the release https://github.com/stcorp/coda/releases/tag/2.24. Let me know if this works.

— Reply to this email directly, view it on GitHub https://github.com/stcorp/coda/issues/90#issuecomment-1142200840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAORLQEIWBAWJ4VVQGESKULVMYN2NANCNFSM5WWSH5VQ. You are receiving this because you authored the thread.Message ID: @.***>

--


dr. J. de Kloe @. @.


svniemeijer commented 2 years ago

Make sure you use the coda-2.24.tar.gz package and not the 'Source code' packages. The 'Source code' packages are just github snapshots created by github itself (and don't contain a configure script indeed).

jdkloe commented 2 years ago

Thanks for pointing this out. You are right, I downloaded the wrong tar file, so this was my mistake.

If I download coda-2.24.tar.gz and run the install again using:

./configure --prefix=pwd/../coda_installed --enable-python make make instal

then all looks fine now. The python module indeed is installed now in pwd/coda_installed/lib/python3.10/

Thanks for your support.

On 07-06-2022 16:23, Sander Niemeijer wrote:

Make sure you use the coda-2.24.tar.gz package and not the 'Source code' packages. The 'Source code' packages are just github snapshots created by github itself (and don't contain a configure script indeed).

— Reply to this email directly, view it on GitHub https://github.com/stcorp/coda/issues/90#issuecomment-1148745362, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAORLQAQKUFS6BGUKQANJVDVN5LNLANCNFSM5WWSH5VQ. You are receiving this because you authored the thread.Message ID: @.***>

--


dr. J. de Kloe @. @.