dataTakeID parameter not included in the MPH of RAWS<PID>_<PC> products

[lmar76]

According to the MPH Definition document v2.3, the bio:dataTakeID parameter:

/bio:EarthObservation/om:procedure/eop:EarthObservationEquipment/eop:acquisitionParameters/bio:Acquisition/bio:dataTakeID

is mandatory for RAWS<PID>_<PC> products.

I used the following configuration for the simulation of the Level-0 Step 1 processing:

{
    "mission": "biomass",
    "scenarios": [
        {
            "name": "20170225T094527 - LPPFStep1_025",
            "file_name": "L0PFStep1",
            "processor_name": "L0PFStep1_025",
            "processor_version": "01.00",
            "task_name": "L0PFStep1",
            "task_version": "01.00",
            "log_level": "debug",
            "data_takes": [
                {
                    "data_take_id": 6632654,
                    "start": "2017-02-25T09:46:04.620Z",
                    "stop": "2017-02-25T09:58:34.884Z"
                }
            ],
            "begin_end_position_from_toi": true,
            "outputs": [
                {
                    "type": "RAWS025_10",
                    "metadata_source": ".*RAW_025_10.*"
                }
            ]
        }
    ]
}

Procsim generates 9 output products but the bio:dataTakeID parameter is not present in the MPH.

Please find in attachment the working directory for the test: WD-L0PFStep1.zip.

[pe1obw]

We don't have version 2.3 of the MPH document we only have 2.1. Is this changed? According to v2.1, the datatakeId is only mandatory for L0, L1, AUX_ATT and AUX_ORB. In fact, not any acquisition parameter is needed for RAWS.

[mivermeu]

In the MPH Definition v2.3 document, page 19, under the description of the dataTakeID element, it is stated that this element may occur more than once for RAWS<PID>_<PC> product types. In our understanding, RAWS products are slice-based and slices always occur within one data take. How is it possible that the MPH of such a product may then contain multiple data take IDs?

[mivermeu]

With the merge of PR #44, RAWS products can now be generated with data take parameters. The data take ID should be included in their MPH.

[lmar76]

I confirm that RAWS products may contain more than one data take. E.g. consider the case where an input RAW contains two data takes (DT1 and DT2) which are separated by 32 seconds (minimum data take separation). The temporal gap is shorter than a slice, thus it may happen that one slice contains final part of DT1 and initial part of DT2.

The issue is fixed!

[lmar76]

Fixed.