search

stcr / subscribe-to-comments-reloaded

Subscribe to Comments Reloaded allows commenters to sign up for e-mail notifications of subsequent replies.
56 stars 32 forks source link

Possible XSS exploit #138

Open IvanRF opened 9 years ago

IvanRF commented 9 years ago

I'm not an expert on this, but I saw you added esc_attr() on POST and GET. Shouldn't you use that also in /options/index.pnp lines 68-71?

Reedyseth commented 9 years ago

I'm not an expert on this, but I saw you added esc_attr() on POST and GET. Shouldn't you use that also in /options/index.pnp lines 68-71?

You are right. Any information coming from any source should be escape, but annotated.

IvanRF commented 9 years ago

Here are some more possible exploits: /options/panel1-business-logic.php lines 94-98

IvanRF commented 9 years ago

Also in

Easiest way to find them is to search "$_GET" or "$_POST" in the whole project.