stdevPavelmc / mailad-ansible-role

Ansible role to install a MailAD server
GNU General Public License v3.0
2 stars 2 forks source link

ADs in a list, perms in postfix/ldap, libldap-common #3

Closed dienteperro closed 1 year ago

dienteperro commented 2 years ago

The three main changes for this pull request are:

  1. Acommodate ADs in a list, in my TODO list for several months. It allows to have just one variable (instead of two) for the AD servers, and IMHO a list does better the task. Something to note is: Do we want to have a mix of secure and not secure ADs in the list, now is coded for all-secure, an easy solution is change the list to a format like this:

    • ldap://non.secure.domain
    • ldaps://secure.domain:636 I think we should prioritize secure servers as a best practice, let's remember that user accounts are crossing the network.
  2. Permissions for folder /etc/postfix/ldap contents were readable by others. The have sensitive info, so I change the code to make it 0640. I suggest to move the creation of the folder to a separate task also so it can be 0750.

  3. As noted some days ago, some recent Debian and Ubuntu deployments don't install /etc/ldap.conf (from package libldap-common). An easy solution is enforce the installation of package libldap-common. I recommend check the necessity of this in future versions. Question is: In future versions of Debian and Ubuntu ldap requires /etc/ldap.conf to make possible the use of ldaps://?

Best regards.

stdevPavelmc commented 1 year ago

First: Thanks for the contribution!

Now onto the business:

Looks good to me, merge in progress!