search

stdevPavelmc / mailad

Software to provision a mail server with users from a Windows or Samba 4 Active Directory
GNU General Public License v3.0
33 stars 11 forks source link

[BUG] Garbage collector script detect all mailboxes as stalled. #132

Closed stdevPavelmc closed 3 years ago

stdevPavelmc commented 3 years ago

Describe the bug

The garbage collector script must detect only stalled mailboxes and it's flagging all mailboxes as garbage. This must hit only users with the latest version.

This is a potential security risk, as it could erase valid mailboxes; thanks to god it's less than a year from the update that introduced the bug.

Work is in progress to address this.

stdevPavelmc commented 3 years ago

Confirmed and root of the problem found: the script https://github.com/stdevPavelmc/mailad/blob/master/scripts/check_maildirs.sh was not updated with the simplified user's handling of the last big change.

So it's not able to identify valid maildirs, so all are stalled ones... my mistake, sorry.

Work is in progress now.

stdevPavelmc commented 3 years ago

Fix is on test bed now, all results looks fine.

stdevPavelmc commented 3 years ago

Testing the fixed script on a live system now...

stdevPavelmc commented 3 years ago

Fix works on test and real environments.

Patch incoming ASAP.