search

stdevPavelmc / mailad

Software to provision a mail server with users from a Windows or Samba 4 Active Directory
GNU General Public License v3.0
33 stars 11 forks source link

[BUG] General grammar revision #143

Closed stdevPavelmc closed 3 years ago

stdevPavelmc commented 3 years ago

Describe the bug Do a general grammar & syntax revision, a job that @dienteperro started.

Please just before commit the change and fill a pull request mention this bug number to get it all under just one issue and fix all them with a simple merge after review.

Remember that in Github all pull request must be bind to a issue.

stdevPavelmc commented 3 years ago

Just mention this issue number on the description of the change, like this:

Related to #143, or fix #143, etc.

stdevPavelmc commented 3 years ago

@dienteperro Thanks for doing this, but please stop making a PR for every file.

In your local fork:

  1. Create a banch
  2. Fix/Improve a file
  3. Commit the change mentioning "fix #143" on the commit line
  4. Iterate from 1 for each file that need fix/improvements
  5. Al the end make a PR, just a PR with all the changes... in one PR...

Cheers.

dienteperro commented 3 years ago

ajjajaja, anotado, solo que no existe local fork.

stdevPavelmc commented 3 years ago

@dienteperro Si, en tu github tienes un fork... allí haz los cambios y luego hacern un PR con todos los cambios...