stdevel / katprep

Python toolkit for automating system maintenance and generating patch reports along with Foreman/Katello and Red Hat Satellite 6.x

GNU General Public License v3.0

35 stars 6 forks source link

Harder requirements #120

Closed okin closed 4 years ago

okin commented 4 years ago

katprept is still running with Python 2.7 and 3.4.

We need to be a little more specific about our requirements here since a lot of libs are dropping support for Python 2 and old 3.x versions.

codecov-io commented 4 years ago

Codecov Report

Merging #120 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   11.06%   11.06%           
=======================================
  Files          16       16           
  Lines        1971     1971           
=======================================
  Hits          218      218           
  Misses       1753     1753

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a6bbf6...2f33c3b. Read the comment docs.

rapgro commented 4 years ago

No. Python2 is announced for EOL. Why don't support any new version of Python3?

rapgro commented 4 years ago

117

okin commented 4 years ago

No. Python2 is announced for EOL. Why don't support any new version of Python3?

I talked to @stdevel in private and my impression was that he wanted to still support RHEL / CentOS 7 and therefore there is support for Python 2.7.

I'm all in for dropping Python 2 support. As a sidenote I'm working on further improving the Python 3 support. But I feel this should be separate discussions.

rapgro commented 4 years ago

Indeed, RHEL / CentOS 7 still has python2. But there's also (rudimental) support for python3, some packages within EPEL additionally that leads me to ensure nothing about all requirements available to get a fully working package. I'd say we should try with python3 in RHEL / CentOS 8 then. Right, it's not the right place to discuss the details here in a PR.

stdevel commented 4 years ago

Sorry for the last delay - I just had no time for katprep due to other projects.

In the meantime I decided to drop support for Python 2.7.x. The most distributions already dropped support for this specific version. Even on EL7 you can't barely live without newer Python versions now as many projects also dropped support.

Thanks for your contribution - just merged your code!

codecov-commenter commented 4 years ago

Codecov Report

Merging #120 into master will increase coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   11.00%   11.06%   +0.05%     
==========================================
  Files          16       16              
  Lines        1971     1971              
==========================================
+ Hits          217      218       +1     
+ Misses       1754     1753       -1

Impacted Files	Coverage Δ
katprep/clients/SpacewalkAPIClient.py	`46.15% <0.00%> (+1.92%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a6bbf6...2f33c3b. Read the comment docs.