Clean-up code - Githubissues

stdevel commented 6 years ago

There are several things that could be cleaned in order to facilitate contributions:

[x] remove various style problems by leveraging an IDE
[x] remove comments to obvious code lines (such as setting logging)
[x] remove unused imports
[ ] add more logging to relevant code lines (such as establishing connections)
[ ] remove unnecessary function NagiosCGIClient.__regexp_matches as it's only used in NagiosCGIClient
[ ] use properties rather than getter/setter (see also https://www.python-course.eu/python3_properties.php and https://stackoverflow.com/questions/2627002/whats-the-pythonic-way-to-use-getters-and-setters)
[ ] clean-up libvirt authentication mess derived from example (https://github.com/stdevel/katprep/blob/master/katprep/clients/LibvirtClient.py#L116)

stdevel commented 6 years ago

Investigating in branch style-code-issue92

stdevel commented 3 years ago

Investigating (again) in branch feat-style-code-92

stdevel commented 3 years ago

Additional ideas:

[ ] remove is_writable() (katprep/__init__.py) as it is only used in katprep/report.py

stdevel / katprep