search

stdlib-js / gsheets

Google sheets integration.
https://stdlib.io
Apache License 2.0
2 stars 3 forks source link

Setup Git hooks similar to main development repository #3

Open kgryte opened 10 months ago

kgryte commented 10 months ago

Prior to committing and pushing, we should run lint processes and, where applicable, run tests, examples, and benchmarks.

Similarly, we should check whether the package.json has changed in order to determine whether to reinstall node modules dependencies.

adityacodes30 commented 6 months ago

I would like to take this up !

kgryte commented 6 months ago

@adityacodes30 Thanks for volunteering. This task should help provide an intro to the repo, at least from a build perspective. Note, however, that the hook commands will not be 1:1 with the main project and will need to be tailored accordingly.

adityacodes30 commented 6 months ago

Understood, will try to imitate the functionality while tailoring it to the structure and implementation of this repo. Since the documentation and everything is in a nascent stage, I will ask the maintainers if i find any ambiguity. Could you please assign it to me as well. Thanks

kgryte commented 6 months ago

Assigned.

adityacodes30 commented 6 months ago

I have been inspecting this issue and have been taking the main repo as reference to the rules and conventions of the directory structure and implementation. I think i now have a fair idea of the structure and requirements.

For me to move ahead with this i will need to create the required make files , some folders such as tools, etc and more. I want to ask if this is the correct approach to take for this project and one i should go ahead with?

kgryte commented 6 months ago

For the make files, I suggest seeing how far you can get adding recipes to the existing Makefile in the root project directory.

For linting tools, I'd create a tools directory in the root project directory and add them there. We can iterate on organization once you have something working.