stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨
https://stdlib.io
Apache License 2.0
4.35k stars 440 forks source link

RFC: add the Boltzmann distribution #179

Open kgryte opened 6 years ago

kgryte commented 6 years ago

Checklist

Please ensure the following tasks are completed before filing an issue.

Description

Description of the issue (or feature request).

This RFC proposes adding the Boltzmann distribution. Similar to other distribution namespaces, adding support for the Boltzmann distribution would entail a family of packages for evaluating the PMF, CDF, mean, median, etc.

Namespace: @stdlib/stats/base/dists/boltzmann Reference: @stdlib/stats/base/dists/*

Related Issues

Does this issue (or feature request) have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue (or feature request)? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

Reference implementations:

AgPriyanshu18 commented 6 months ago

@kgryte I would like to work on this issue.

kgryte commented 6 months ago

@AgPriyanshu18 Thanks for volunteering to work on this. Feel free to submit one or more PRs implementing this functionality. In fact, it may be good to split it over multiple PRs just to simplify review.

AgPriyanshu18 commented 6 months ago

@kgryte @Planeshifter, I have stuck on linkting issues with Readme file. Screenshot from 2024-04-02 09-59-39

The code block on readme file giving issue is Screenshot from 2024-04-02 10-00-46

PMF Factory method code block is Screenshot from 2024-04-02 10-01-45

There is no variable named fact in Readme. I would request your help in this issue.

kgryte commented 6 months ago

But there is a variable named fact in your pmf function, and you haven't declared it. You need to add var fact; to the pmf function you show in your last screenshot.

AgPriyanshu18 commented 6 months ago

@kgryte @Planeshifter Thanks for your help. I have added the PMF function for Boltzmann distribution.