[RFC]: update `math/base/special/atanh` according to the FreeBSD implementation

stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨

https://stdlib.io

Apache License 2.0

4.58k stars 513 forks source link

[RFC]: update `math/base/special/atanh` according to the FreeBSD implementation #2089

Open gunjjoshi opened 8 months ago

gunjjoshi commented 8 months ago

Description

This RFC proposes updating the C implementation for math/base/special/atanh, according to the FreeBSD implementation.

We need to convert the floating-point value to a word and then perform integer calculations, as given in the original FreeBSD implementation.

Related Issues

None.

Questions

No.

Other

No.

Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Deepakchowdavarapu commented 3 months ago

@gunjjoshi I would like to solve this issue

gunjjoshi commented 3 months ago

@Deepakchowdavarapu Thanks for volunteering, go ahead!

Deepakchowdavarapu commented 3 months ago

Hi @gunjjoshi , I've updated the atanh implementation as described in issue #2089. Could you please review my work in PR #2746? Also, if possible, I'd appreciate it if you could assign this issue to me. Thanks for your time and consideration!

RiyaChy072 commented 1 week ago

@gunjjoshi Can i try to work on this issue? Is it open?

gunjjoshi commented 1 week ago

@RiyaChy072 Yes, feel free to submit a PR for this.

RiyaChy072 commented 1 week ago

@gunjjoshi Can you kindly check if it's done or not? And kindly let me know if i should add more changing files. Also accept my apology for committing the contributor's list. It was accidentally happened and don't know what to do with it, as an absolute beginner. Thanks.