[RFC]: Add C implementation for `@stdlib/math/base/special/minmax` - Githubissues

stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨

https://stdlib.io

Apache License 2.0

4.56k stars 511 forks source link

[RFC]: Add C implementation for `@stdlib/math/base/special/minmax` #2106

Open anirudhprabhakaran3 opened 7 months ago

anirudhprabhakaran3 commented 7 months ago

Description

This RFC proposes to add a C implementation for @stdlib/math/base/special/minmax

Related Issues

Progresses #649

Questions

I note that the implementations of min and max are already available. Should the C implementation exactly follow the logic in the JS files, or could it use the min and max functions in C while maintaining the same function signature and return values?

Other

No.

Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

kgryte commented 7 months ago

@anirudhprabhakaran3 Sorry to be the bearer of bad news, but there is already a PR up for minmax: https://github.com/stdlib-js/stdlib/pull/1939.

anirudhprabhakaran3 commented 7 months ago

Aah😔 seems like I have the worst luck coming to this!

Aditya8840 commented 6 months ago

@kgryte I'd like to work on this.