search

stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨
https://stdlib.io
Apache License 2.0
4.33k stars 441 forks source link

[@stdlib/math/base/special/haversin] Incorrect operator in definition equation image #301

Closed Andrew-Cottrell closed 4 years ago

Andrew-Cottrell commented 4 years ago

https://github.com/stdlib-js/stdlib/blob/19d5e91311a86c4888d22ca055c4924b3a32ffd4/lib/node_modules/%40stdlib/math/base/special/haversin/README.md

The definition equation image has a plus (+) operator where a minus (−) operator should be.

kgryte commented 4 years ago

@Andrew-Cottrell You're right! Will fix shortly. Thanks for catching this!

Andrew-Cottrell commented 4 years ago

FYI, the image continues to display the incorrect operator. I guess an automated or manual build step is required to re-generate the equation_haversine.svg file.

https://github.com/stdlib-js/stdlib/blob/b4d11aac1aa74441653f0ba195a184fd5cc51de0/lib/node_modules/%40stdlib/math/base/special/haversin/docs/img/equation_haversine.svg

kgryte commented 4 years ago

@Andrew-Cottrell You're right! Forgot to regenerate the SVG and update the image URL. Doing now...

kgryte commented 4 years ago

@Andrew-Cottrell Should be fixed now!

Andrew-Cottrell commented 4 years ago

Looks good to me 🙂

kgryte commented 4 years ago

@Andrew-Cottrell Great! Thanks for flagging this!