stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨
https://stdlib.io
Apache License 2.0
4.53k stars 503 forks source link

feat: add C implementation for `math/base/special/minmaxabs` #3181

Open AbhijitRaut04 opened 3 days ago

AbhijitRaut04 commented 3 days ago

Resolves #1942 .

Description

This PR contains the C implementation for minmax function

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Tests image.

Bemchmarks image

Examples image

addon.c image

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot commented 3 days ago

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.
  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot commented 3 days ago

Coverage Report

Package Statements Branches Functions Lines
math/base/special/minmax $\color{green}195/195$
$\color{green}+100.00\%$
$\color{green}15/15$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}195/195$
$\color{green}+100.00\%$
math/base/special/minmaxabs $\color{green}257/257$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}257/257$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

AbhijitRaut04 commented 3 days ago

@Planeshifter @kgryte Please take a review and suggest me if any changes required.

kgryte commented 21 hours ago

/stdlib lint-autofix