stdlib-js / stdlib

✨ Standard library for JavaScript and Node.js. ✨
https://stdlib.io
Apache License 2.0
4.56k stars 509 forks source link

refactor: update docs and handling of zero stride of `blas/ext/base/dapxsumkbn` #3212

Closed headlessNode closed 5 days ago

headlessNode commented 5 days ago

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot commented 5 days ago

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dapxsumkbn $\color{green}392/392$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}392/392$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

headlessNode commented 5 days ago

@kgryte The test failure here is from a downstream test suite. I'll update it once this PR is merged.

kgryte commented 5 days ago

@headlessNode This is already merged, but I just saw that we are still using fabs in the implementation. We can migrate to using @stdlib/math/base/special/abs.