stdlib-js / www

Website for stdlib, a standard library for JavaScript and Node.js.
https://stdlib.io
Apache License 2.0
7 stars 8 forks source link

[Bug] For web accessibility, side menu items should be links, not buttons #12

Closed kgryte closed 2 years ago

kgryte commented 2 years ago

Checklist

Please ensure the following tasks are completed before filing a bug report.

Description

Description of the issue.

Currently, the docs side menu renders navigation elements as <button> elements, rather than <links>. This breaks user expectations regarding behavior (i.e., navigating to new content) and ability to right-click and, e.g., open in a new tab or window.

Preferably, the markup would be refactored to use anchor <a> tags, rather than <button> tags.

Related Issues

Does this issue have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

Demo

If relevant, provide a link to a live demo.

For a live demo of the issue, see

Reproduction

What steps are required to reproduce the unexpected output?

In order to reproduce this bug, do the following:

Expected Results

What are the expected results?

The following results are expected:

Actual Results

What are the actual results?

The following are the actual results:

Environments

What environments are affected (e.g., Node v0.4.x, Chrome, IE 11)? If Node.js, include the npm version, operating system, and any other potentially relevant platform information.

The following environments are affected:

kgryte commented 2 years ago

This has now been addressed. Side menu items are now links, rather than buttons.