stdlib-js / www

Website for stdlib, a standard library for JavaScript and Node.js.
https://stdlib.io
Apache License 2.0
6 stars 8 forks source link

[Bug]: settings menu close button only triggers a close when click directly on icon and not entire button #43

Closed kgryte closed 2 years ago

kgryte commented 2 years ago

Description

Encountered an error when attempting to close the settings menu by clicking on the close menu button. The hover state indicates that the button is active and clicking triggers a ripple effect, but the menu does not close. This is likely due to the listener being set on the wrong element.

Related Issues

None.

Questions

No.

Demo

No response

Reproduction

-   open the settings menu.
-   try closing the menu without explicitly clicking on the `x` icon.

Expected Results

The menu should close.

Actual Results

The close button ripples, but does not close.

Environments

Firefox, Chrome, Safari, Microsoft Edge, Internet Explorer, Other Browser

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

kgryte commented 2 years ago

This has been addressed.