search

stdmod / puppet-elasticsearch

Puppet module for ElasticSearch based on stdmod naming standards
Other
0 stars 1 forks source link

Keeping any non stdmod parameters at the bottom of parameters list. #1

Closed rdrgmnzs closed 9 years ago

rdrgmnzs commented 11 years ago

One of the things that has frustrated me in the past is trying to find any non standard parameters amongst the standard parameters.

As an example "$java_heap_size" in "init.pp", I would suggest that we place any such parameters after the stdmod parameters. It would make these variables easier to locate as well as keep the code a little more consistent.

alvagante commented 11 years ago

+1 in keeping the params separated. In the NextGen modules I tended to place the non standard ones at the beginning, but the principle is the same.