search

steadyequipment / node-firestore-backup

Google Firebase Firestore backup tool
190 stars 51 forks source link

Parallel #20

Closed jeremylorino closed 6 years ago

jeremylorino commented 6 years ago

Working towards resolution of #16 will reference #4 because there was conversation regarding this in the issue.

jeremylorino commented 6 years ago

@yoiang check it. this should solve #16 with CLI params included.

also brings codacy to almost 100% across the board. all issues squashed except one.

yoiang commented 6 years ago

The only thing I'd say is it would be great to have bluebird as an optional dependency rather than required and have the backup code's contents largely agnostic which still taking advantage of bluebird's or any future Promise libraries particulars. This may be having my cake and eating it too ;)

I apologize, I didn't thank you for this work earlier up, this is great! 😄

jeremylorino commented 6 years ago

@yoiang how about this

removed bluebird as a dependency and localized the use of Promise inside FirestoreBackup and allows it to be overridden after initialization.

we can add bluebird back after this and use it if we want.

yoiang commented 6 years ago

It looks great, thank you again :)]