stealjs / rfcs

A place to discuss higher level changes to Steal
MIT License
2 stars 0 forks source link

Add the tree shaking RFC #20

Closed matthewp closed 6 years ago

matthewp commented 6 years ago

Rendered

frank-dspeed commented 6 years ago

@matthewp i see a other problem not handled what if i plan to use dynmaic something that i expect exportet? For example i require underscore and later some function in my consumer code wants to use that dynamic and expects that all methods are use able? we need a tree shake ignore formart for the package.json glob or object based is the question if we would supply path info somehow like in my tar example we could go with glob i think else we need to solve that on package name?

matthewp commented 6 years ago

@frank-dspeed If a module is dynamically imported then it should not be tree shaken. I'll update the RFC with that information.

matthewp commented 6 years ago

This RFC is entering final comment period. It will be merged in 7 days.

matthewp commented 6 years ago

Waited too long, this is being merged 🎸