stealjs / steal-conditional

Conditional loading
https://stealjs.com/docs/steal-conditional.html
MIT License
6 stars 1 forks source link

Glob file system to locate substitution variations #24

Closed m-mujica closed 7 years ago

m-mujica commented 7 years ago

Closes #22

so @matthewp I have a couple of issues getting to work this:

screen shot 2016-11-24 at 16 19 47

do you see anything in the code that might be easier to approach in a different way?

m-mujica commented 7 years ago

I've been also thinking about the scenario where someone imports a module like

import '#{foo}';

With my current changes, we'd glob for the root project folder and the number of matches will be pretty big. I guess we can document that doing this is a bad idea, can we do better?

m-mujica commented 7 years ago

So, I'm trying a slightly different approach for the string interpolation

This is working fine, I'm steal dealing with the problem of steal loading dist/glob on production mode when the app is minified, I noticed the error doesn't happen if minify is set to false.