search

stealjs / steal-conditional

Conditional loading
https://stealjs.com/docs/steal-conditional.html
MIT License
6 stars 1 forks source link

Boolean Conditional is not working #33

Closed pYr0x closed 7 years ago

pYr0x commented 7 years ago

a import like require('~/modules/notice-box#?triwala-vk/modules/notice-box-exists'); where triwala-vk/modules/notice-box-exists is the module that exports a boolean does not work.

a error is thrown Condition modules cannot contain . or / in the name https://github.com/stealjs/steal-conditional/blob/master/conditional.js#L58

@m-mujica do you know why . and / is forbidden?

matthewp commented 7 years ago

I think / is the problem here, it shouldn't be forbidden should it?

m-mujica commented 7 years ago

@matthewp @pYr0x the restriction on using / was inherited from the original implementation. I can't remember why it was done that way..... I'll try to remove that and see how it goes.

pYr0x commented 7 years ago

@m-mujica and news about this issue?

m-mujica commented 7 years ago

@pYr0x I plan to work on this in my spare time or after I'm done with the dev bundle stuff....

m-mujica commented 7 years ago

@pYr0x just released v0.3.3. Please, give it a try when you have a chance and let me know how it goes.