search

stealjs / steal-css

StealJS plugin for CSS
https://www.npmjs.com/package/steal-css
MIT License
2 stars 1 forks source link

Handle IE9 stylesheet limit #40

Closed m-mujica closed 7 years ago

m-mujica commented 7 years ago

https://github.com/stealjs/steal/issues/123

bs_win7_ie_9 0 bs_win7_ie_9 0 1

m-mujica commented 7 years ago

hmm got some tests failures in Firefox and Safari, too. It seems my fixed timeout wasn't doing the trick...

I just pushed a polling based approach to wait for the css or timeout kinda like Funcunit. Hopefully this makes it so modern browsers run tests fast and we get the failure only in IE9

m-mujica commented 7 years ago

💥 that's what I'm talking about

google chrome

...time to add the hack

m-mujica commented 7 years ago

@matthewp I need to keep some state (ugh! I know) in steal-css, keep the count of stylesheets, the last one created and stuff.

I'm having trouble to get it to work, the module is eval-ed everytime a css file is loaded, adding stuff to the global object does not work (ugh, I know ++).

Thoughts?

matthewp commented 7 years ago

The module is evaled every time a css file loads? That doesn't sound right, must be something going on there, right?

matthewp commented 7 years ago

👍 LGTM