search

stealjs / steal-less

A less plugin for StealJS
https://www.npmjs.com/package/steal-less
MIT License
4 stars 2 forks source link

Repetitive code in less.js #7

Closed akagomez closed 7 years ago

akagomez commented 9 years ago

It seems unnecessary to repeat these lines: 

    var pathParts = (address+'').split('/');
        pathParts[pathParts.length - 1] = ''; // Remove filename

    if (typeof window !== 'undefined') {
        pathParts = (load.address+'').split('/');
        pathParts[pathParts.length - 1] = ''; // Remove filename
    }

https://github.com/stealjs/steal-less/blob/master/less.js#L15-L21

Maybe this happened as a result of a bad merge?

matthewp commented 9 years ago

Does look wrong, why is this only happening in a window I wonder.

matthewp commented 7 years ago

This was fixed a while back.