search

stealjs / steal-less

A less plugin for StealJS
https://www.npmjs.com/package/steal-less
MIT License
4 stars 2 forks source link

update less.js dependency to get fix for reference imports #74

Closed nlundquist closed 6 years ago

nlundquist commented 6 years ago

Less 2.6.0 contains a fix for reference imports. In previous implementations these were buggy and didn't operate as the less docs indicated. This is a very useful feature for avoiding global LESS styles being inserted into your component stylesheets.

I've tested this in a large scale app and it resolves the issue I was seeing with Less.js 2.5.3. Additionally it doesn't appear to produce the bug noted here https://github.com/stealjs/steal-less/pull/61

nlundquist commented 6 years ago

I also tested with the most recent version of less.js@3.8.1, it also passed all tests and worked when tested in the application. I could update this PR to skip ahead to that version, though I'd expect we'd want to do more thorough testing if we did that.

matthewp commented 6 years ago

I don't totally understand if this would be a breaking change... But it's fine if it is. So whichever you feel most comfortable with.