search

stealjs / steal-socket.io

A small wrapper that lets you use socket.io on the client and server
MIT License
2 stars 3 forks source link

Multiple connections #13

Closed marshallswain closed 7 years ago

marshallswain commented 7 years ago

Allows multiple connections to be made. Includes #12.

ilyavf commented 7 years ago

@marshallswain The parameter forceNew is not defined for socket.io, is it? If its not, then we probably need to do something else. I think we have to mimic what socket.io is doing in the same case, and don't add our own custom param.

marshallswain commented 7 years ago

@ilyavf Yes, forceNew is a socket.io param that forces it to build a new socket connection instead of using an existing one.

ilyavf commented 7 years ago

Yeah, you are right, it is, I just didnt find it in docs. There is also an alias called "force new connection", and one more option multiplex.

marshallswain commented 7 years ago

@ilyavf do you know if the meta config is still needed in the package.json? I think it is left over from before they changed the socket.io-client folder structure.

marshallswain commented 7 years ago

For when we continue work on this:

The delayIO module should duplicate the functionality of socket.io library, which creates an internal manager for each call to io(‘’) with a unique URL. Right now we are not allowing it to create all managers. Only the default manager is in place.

marshallswain commented 7 years ago

@ilyavf once we get https://github.com/canjs/can-fixture-socket/issues/13 completed, we can update the dependency here: https://github.com/stealjs/steal-socket.io/pull/13/commits/344e3960412e32e75af3fe44bb061b6981905fdf#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R29