search

stealjs / steal-tools

Build easy. Load fast.
https://stealjs.com/docs/steal-tools.html
MIT License
67 stars 23 forks source link

Fix css bundles lookup in development bundles #1000

Closed m-mujica closed 6 years ago

m-mujica commented 6 years ago

Regular production bundles are always written out to "bundles/*", when a custom "dest" is used, setting "bundlesPath" is needed to make sure the defaults paths in System.paths point to the correct location of the bundles.

Development bundles are not written out to "bundles/*"; the fix in this case consisted on adding "dest" to the bundle name used in the System.bundles configuration added by steal-tools. This way the System bundle extension can locate the file correctly when custom "dest" values are used.

Renaming the bundle name in the dependency graph brakes the logic to write out the bundles, hence why the bundle name including "dest" is only used in the bundle configuration output.

Closes #999

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 93.323% when pulling 3310c702db3d6ff49417575eec1564a2001802f1 on dev-bundle-css into cfc9cb80fc82a9bdf204aa651e7acea818b80046 on master.

matthewp commented 6 years ago

👍 Looks good