search

stealjs / steal-tools

Build easy. Load fast.
https://stealjs.com/docs/steal-tools.html
MIT License
66 stars 23 forks source link

Fix integration with rollup-plugin-commonjs #1125

Closed chasenlehara closed 5 years ago

chasenlehara commented 5 years ago

steal-tools started to break as of rollup-plugin-commonjs@9.3.3 with this error:

TypeError: Cannot read property 'load' of undefined
 at exports.moduleNameFromSpecifier (lib/node/dependency_resolver.js:9:194)
 at resolveId (lib/bundle/concat_source_es.js:9:2882)
 at node_modules/steal-rollup/dist/rollup.js:5980:113

As far as I know, this isn’t a bug on their end and we need to fix our integration with that package.

Here’s the issue Greenkeeper originally filed: https://github.com/stealjs/steal-tools/issues/1121

For now, we have this semver range to avoid the issue: https://github.com/stealjs/steal-tools/blob/003ec65c5b61728d58ac0ff276d125a4ebbd839d/package.json#L33