search

stealjs / steal-tools

Build easy. Load fast.
https://stealjs.com/docs/steal-tools.html
MIT License
66 stars 23 forks source link

Should CI run more than test:browser? #1126

Open chasenlehara opened 5 years ago

chasenlehara commented 5 years ago

Right now, Travis only runs the test:browser script:

https://github.com/stealjs/steal-tools/blob/003ec65c5b61728d58ac0ff276d125a4ebbd839d/.travis.yml#L13

The test script has a lot more in it: https://github.com/stealjs/steal-tools/blob/003ec65c5b61728d58ac0ff276d125a4ebbd839d/package.json#L89

I added release scripts and only included test:browser in the preversion script because other tests weren’t passing for me locally.

https://github.com/stealjs/steal-tools/blob/003ec65c5b61728d58ac0ff276d125a4ebbd839d/package.json#L96

Is this expected? Should CI run other tests too? What should be run locally?