search

stealjs / steal-tools

Build easy. Load fast.
https://stealjs.com/docs/steal-tools.html
MIT License
66 stars 23 forks source link

Update Node version to 13 #1153

Closed cherifGsoul closed 4 years ago

cherifGsoul commented 4 years ago

Closes #1151

Update node engine field in package.json and .travis.yml to 13.x.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 94.049% when pulling 9076f15868a3cebccd2fe84fa34bcc38007ee2e2 on upgrade-node-12 into 58df60c08a9ef14b19855dcdab634e062b4d22f4 on master.

matthewp commented 4 years ago

You might also need to update mock-fs, that might be the cause of the tests failing.

cherifGsoul commented 4 years ago

@matthewp Thank you, it fixed it, just for windows it can not find C:\stealconfig.js file.

matthewp commented 4 years ago

I think that's expected as part of that test. It looks like the error on Windows is something else, look at the stack trace: https://ci.appveyor.com/project/matthewp/steal-tools-427/builds/29763981

cherifGsoul commented 4 years ago

@matthewp What is the windows version and architecture used in appveyor? Firefox is not found in appveyor but works fine on my local image, maybe a lauchpad issue, the build passes with chrome.

matthewp commented 4 years ago

Awesome, looks good to me 👍