search

stealjs / steal-tools

Build easy. Load fast.
https://stealjs.com/docs/steal-tools.html
MIT License
66 stars 23 forks source link

Add support for node 14 (modelled after #1153) #1157

Closed icarito closed 4 years ago

icarito commented 4 years ago

Untested

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.3%) to 92.735% when pulling 3653db422886a91b3e966dd591b32d6351569ffa on icarito:update_node into d6a0a978e397c4c2b266b3f003bb7a3f702ba21d on stealjs:master.

icarito commented 4 years ago

This works in my scenario, but there are a few warnings.

(node:1556) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:2236) Warning: Accessing non-existent property 'VERSION' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)

Also a lot of warnings about outdated dependencies (e.g. Chokidar, etc, see AppVeyor). I guess those are separate issues.

matthewp commented 4 years ago

Thanks!