stealjs / steal

Gets JavaScript
https://stealjs.com
MIT License
1.37k stars 522 forks source link

Correctly encode git+ssh dependencies #1459

Closed matthewp closed 6 years ago

matthewp commented 6 years ago

Dependencies that use git+ssh can create moduleNames that interfere with steal's moduleName parsing. URLs such as:

git+ssh://git@example.com/company/my-lib.git#c23dr61

Are problematic because they contain both an @ and a # which have special meaning.

The solution here is to encode the version number. For normal versions like 1.0.0 this will not change anything. Only for these weird versions that are actual URLs.

Fixes #1324