search

stealjs / steal

Gets JavaScript
https://stealjs.com
MIT License
1.37k stars 521 forks source link

warn with the importer in case of missing module #1493

Closed cherifGsoul closed 5 years ago

cherifGsoul commented 5 years ago

This adds the importer file of a missing module to the error message by prepending the stack to error.

Fixes https://github.com/stealjs/steal/issues/1463

matthewp commented 5 years ago

Looks good now 👍

matthewp commented 5 years ago

I think the test is not working. I don't think the "dep" is being imported so the error does not occur. This is what is happening in CI:

screen shot 2019-01-14 at 5 59 54 pm
cherifGsoul commented 5 years ago

@matthewp I fixed the test, the dep file was inside node_modules which is ignored, can take a look please (tomorrow).

matthewp commented 5 years ago

Looks good!