search

stealjs / steal

Gets JavaScript
https://stealjs.com
MIT License
1.36k stars 522 forks source link

Use a stricter RegExp to detect System.register modules #1501

Closed m-mujica closed 5 years ago

m-mujica commented 5 years ago

Fixes #1500

matthewp commented 5 years ago

Tests failing.

giphy

m-mujica commented 5 years ago

Ok, so initially the tests failed because of an old appium-version.

I fixed that, but now I get an actual test failure on the iphone 7.

0002screenshot

I'm going to try to debug this, and in the meantime I'll re-run the tests to make sure the issue is consistent.

m-mujica commented 5 years ago

Ended up skipping the tests for safari, it didn't seem like a simple fix... Created an issue to tackle the stack trace in Safari later.