Open nlundquist opened 5 years ago
@nlundquist do you have a repo where I can replicate this issue?
I just tried with:
{
"name": "steal-crawl-issue",
"version": "1.0.0",
"main": "main.js",
"dependencies": {
"can": "canjs/canjs#master"
},
"devDependencies": {
"steal": "^2.2.2",
"steal-tools": "^2.2.2"
}
}
and
{
"name": "steal-crawl-issue",
"version": "1.0.0",
"main": "main.js",
"dependencies": {
"can": "^5.0.0",
"can-legacy-view-helpers": "canjs/can-legacy-view-helpers#can-5-compat"
},
"devDependencies": {
"steal": "2.2.2",
"steal-tools": "2.2.2"
}
}
both apps build without errors (I'm importing the module using the shorthand in my code).
Reproducible: Always
When using an NPM compatible shorthand for a GitHub hosted dependency ie:
rather than:
Though the application works fine in dev mode, a Steal build fails with the following:
build - buildResult TypeError: Cannot read property 'steal' of undefined at Object.config (VM1439 npm-utils.js:564) at Object.getDependencyMap (VM1441 npm-crawl.js:242) at Object.loadPlugins (VM1441 npm-crawl.js:181) at VM1441 npm-crawl.js:107
Environment:
Note: This same failure occurs when using a valid Git URL (rather than shorthand) of the form
git+ssh://git@github.com:canjs/can-ejs#can-5-compat"
. Steal only appears to play nice with Git URLs that are prefixed withgit+https://
.