stealjs / system-bower

[DEPRECATED] SystemJS and StealJS Bower plugin
MIT License
2 stars 1 forks source link

Root bowerIgnore should be persisted when parsing dependent bower.json #25

Open matthewp opened 8 years ago

matthewp commented 8 years ago

@jcavanagh commented on Thu Jul 09 2015

When using the bowerIgnore feature, bad bower.json requests still occur if a bower dependency also references the ignored dependency in their own bower.json file.

This seems to happen because the bower plugin reads each bower.json individually, and it's obviously not going to find a system.bowerIgnore section in a dependency's bower.json. So, it seems the bower plugin should apply the root bowerIgnore all the way down the dependency chain as well.


@matthewp commented on Wed Jul 15 2015

I think I understand what you are saying. Let me know if this is correct:

root bower.json

{
  "dependencies": {
    "a": "0.0.1",
    "b": "0.0.1"
  },
  "system": {
     "bowerIgnore": ["b"]
  }
}

a bower.json

{
  "dependencies": {
    "b": "0.0.1"
  }
}

b's bower.json will still be fetched. Is this the problem you are describing?


@jcavanagh commented on Wed Jul 15 2015

Yes, indeed - that is correct.