search

stealthmonkey99 / OctoPrint-PWMBuzzer

M300 gcode handler (PWM buzzer via GPIO) for OctoPrint
6 stars 1 forks source link

shutdown event only plays partially now that it is not blocking #13

Closed stealthmonkey99 closed 2 years ago

stealthmonkey99 commented 2 years ago
  1. install the plugin from the main branch, where changes to make m300 tones non-blocking are merged in
  2. set a tune to play for the Shutdown event
  3. restart OctoPrint to test out the event

EXPECTED: tune plays fully upon shutdown ACTUAL: tune only plays a single note as the system shuts down

stealthmonkey99 commented 2 years ago

NOTE: per the ShutdownPlugin warning we should not perform long-running operations... I wonder if it might be acceptable to allow a tune to play out, up to a maximum threshold (short, maybe 3sec)?