search

stealthybox / container-builder-github-ci-status

Google Cloud Function responds to PubSub events on the cloud-builds topic to update GitHub CI status.
MIT License
23 stars 4 forks source link

Last step is misreported as failure step #5

Open max-sixty opened 6 years ago

max-sixty commented 6 years ago

If there are multiple steps running when a failure occurs, the latest task to start is reported as the failure reason, rather than the task with status=FAILURE

image

In the report from cloud container builds describe, isort has a (very slightly!) later start time:

  id: run-tests
  status: FAILURE
  timing:
    endTime: '2018-04-22T18:51:47.129276336Z'
    startTime: '2018-04-22T18:41:13.672572721Z'
[...]
  id: isort
  status: SUCCESS
  timing:
    endTime: '2018-04-22T18:41:28.186709447Z'
    startTime: '2018-04-22T18:41:13.672967786Z'
stealthybox commented 6 years ago

Thanks for reporting this @maxim-lian 👋 I think the status field is new, so we can probably rewrite the filter to use that: https://github.com/stealthybox/container-builder-github-ci-status/blob/94d715be8a1135b73470b49644d982182c821291/index.js#L53-L56

stealthybox commented 5 years ago

I was able to grab a failing build that demonstrates this issue. I've started writing the necessary patch.