search

steamclock / netable

A Swift library for encapsulating network APIs using Codable in a type-oriented way.
MIT License
99 stars 3 forks source link

Better handle decoding arrays of values #104

Closed brendanlensink closed 1 year ago

brendanlensink commented 1 year ago

Right now, if you make a request that's meant to return an array of objects, and one of those objects fails to decode, the entire request fails.

This is a little unexpected to me, I would have expected that the array return all of the objects that successfully decoded and just skipped the un-decodable value.

I think we should probably include an option in the config to toggle this behaviour, but it seems useful to atleast offer the choice to users

amyoulton commented 1 year ago

@brendanlensink @jenncoop hey! I was just look at this and I believe this is actually completed. It got assigned to me but I am fairly certain that this is the lossy array stuff that brendan was working on before the holidays, which is now live! If I'm correct, the merged PR is here. Should we close this?

brendanlensink commented 1 year ago

Sure is!