search

steamclock / netable

A Swift library for encapsulating network APIs using Codable in a type-oriented way.
MIT License
99 stars 3 forks source link

Drop Cocoapods support #87

Closed brendanlensink closed 3 years ago

brendanlensink commented 3 years ago

I had previously updated the podfile to show the new version number, this reverts that and adds a note that the pod is deprecated in favour of SPM.

I think we should delete the podfile in a later commit?

nbrooke commented 3 years ago

Is there a reason not to just delete the Podfile now? It seems weird to have it still in the repo but not mentioned in the Readme (even that it is deprecated) and out of date. I think anyone that wanted to continue using the older version through Cocoapods would need to point it at an older version of the repo by commit / tag anyway, but maybe Im misunderstanding something about how Cocoapods works.

brendanlensink commented 3 years ago

I'm also not certain I've got this right, but my understanding is that if we were to just delete the podfile here, it would still show up on the Cocoapods trunk as the old version, with no indication that we've moved past that version and that it's deprecated.

nbrooke commented 3 years ago

If that's the case, can we EVER delete the Podfile? Or will Cocoapods eventually pick up the deprecation and then we can delete it?

In any case, if we think it's to dangerous to delete than this change seems fine to me 🚀

brendanlensink commented 3 years ago

My assumption is that we can push up this change, update the pod, then delete the podfile and we should be good to go.