steamcmd / api

Read-only API interface for steamcmd app_info
https://www.steamcmd.net
MIT License
56 stars 7 forks source link

Allow Redis URL for hosts that provide a Redis connection string #42

Closed sxalexander closed 1 year ago

sxalexander commented 1 year ago

For many cloud platforms (heroku, render, railway, fly.io) Redis connection info is provided via a connection string (ie. a REDIS_URL environment var)

It would be great to allow the use of REDIS_URL as an option along side the setting seperate env variables to make it easier to run on those platforms.

jonakoudijs commented 1 year ago

This looks like a non-breaking improvement! Thank you for taking the time to make the PR as well.

Let me test it this weekend to make sure nothing will break and I can merge it :)

jonakoudijs commented 1 year ago

The change has been merged and deployed in v1.13.0. The deployment to Fly.io however fails, I will have a look at that later. Can you verify that this change solves your problem on your end?

Thanks again for your contribution :)

jonakoudijs commented 1 year ago

Just tested this on Fly.io and apparently the failed deployment from yesterday was an issue at the Fly.io side. The deployment now works fine as expected.

sxalexander commented 1 year ago

Glad to hear it, thanks for merging 👍🏾 I've got this running on Render now with no issues as well